AVRO-3217: Allow any identifier as annotation name#1414
Merged
RyanSkraba merged 1 commit intoapache:masterfrom Dec 4, 2021
Merged
Conversation
A field schema can be annotated with the property `avro.java.string`:
{
"name": "fieldName",
"type": {
"type": "string",
"avro.java.string": "String"
}
}
The corresponding IDL is:
@avro.java.`string`("String") string fieldName;
The IDL parser fails on the `. This change fixes that.
RyanSkraba
approved these changes
Dec 4, 2021
Contributor
RyanSkraba
left a comment
There was a problem hiding this comment.
LGTM !
I've been away from the project for a few weeks -- thanks so much for your patience and for doing these IDL fixes (especially for doing them in these nice, digestible PRs). I should have a bit more time to get some reviews done!
RyanSkraba
pushed a commit
that referenced
this pull request
Dec 4, 2021
A field schema can be annotated with the property `avro.java.string`:
{
"name": "fieldName",
"type": {
"type": "string",
"avro.java.string": "String"
}
}
The corresponding IDL is:
@avro.java.`string`("String") string fieldName;
The IDL parser fails on the `. This change fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field schema can be annotated with the property
avro.java.string:The corresponding IDL is:
The IDL parser fails on the `. This change fixes that.
Make sure you have checked all steps below.
Jira
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.Tests
OR does not need testing for this extremely good reason:Adjusted the
simple.avdlandsimple.avprtestCommits
Documentation