Skip to content

AVRO-3335 Evaluate input of GenerateNames#1485

Merged
martin-g merged 2 commits intoapache:masterfrom
KyleSchoonover:AVRO-3335
Feb 1, 2022
Merged

AVRO-3335 Evaluate input of GenerateNames#1485
martin-g merged 2 commits intoapache:masterfrom
KyleSchoonover:AVRO-3335

Conversation

@KyleSchoonover
Copy link
Contributor

Additionally updated naming since it does not need to preserve Java like naming.

Jira

Tests

  • My PR adds the following unit tests: Test that method throws new exception

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the C# label Jan 31, 2022
@martin-g martin-g merged commit 9c2464c into apache:master Feb 1, 2022
martin-g pushed a commit that referenced this pull request Feb 1, 2022
* AVRO-3335 Evaluate input of GenerateNames

* Updated to include obsolete method calls.

Co-authored-by: Kyle T. Schoonover <Kyle.T.Schoonover@nordstrom.com>
(cherry picked from commit 9c2464c)
@martin-g
Copy link
Member

martin-g commented Feb 1, 2022

Thank you, @KyleSchoonover !

@KyleSchoonover KyleSchoonover deleted the AVRO-3335 branch February 3, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants