Skip to content

Conversation

@zcsizmadia
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@martin-g
Copy link
Member

The C# interop Github Actions checks didn't run for some reason.
Merging ...
Let's see whether they will run in #1552

@martin-g martin-g merged commit 03de623 into apache:avro-3407-interop-tests-for-user-metadata Feb 19, 2022
martin-g added a commit that referenced this pull request Feb 19, 2022
* AVRO-3407: Test for user metadata in the interop tests

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* Add user_metadats interop tests in C# (#1554)

Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>

Co-authored-by: Zoltan Csizmadia <zcsizmadia@gmail.com>
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
martin-g added a commit that referenced this pull request Feb 19, 2022
* AVRO-3407: Test for user metadata in the interop tests

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* Add user_metadats interop tests in C# (#1554)

Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>

Co-authored-by: Zoltan Csizmadia <zcsizmadia@gmail.com>
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
(cherry picked from commit 7a85764)
@zcsizmadia
Copy link
Contributor Author

Probably it was because I did a PR into your branch, which did not trigger the gitflow action, becuase it is triggered only when PR is made to master or changes to those PRs (to master). Sorry if I overcomplicated

@martin-g
Copy link
Member

martin-g commented Feb 19, 2022 via email

@zcsizmadia zcsizmadia deleted the avro-3407-interop-tests-for-user-metadata-csharp branch February 19, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants