Skip to content

AVRO-3522: Better logging in tests #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martin-g merged 6 commits into from
May 22, 2022
Merged

AVRO-3522: Better logging in tests #1690

martin-g merged 6 commits into from
May 22, 2022

Conversation

@martin-g
Copy link
Member

@martin-g martin-g commented May 17, 2022

Jira

Tests

  • My PR improves some unit and IT tests

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • The new module is documented in its README.md

martin-g added 4 commits May 17, 2022 21:36
@martin-g
AVRO-3522: Use ctor crate to setup/teardown tests
fdbfd6f 
Use TestLogger for all tests. Now it delegates to env_logger too

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
AVRO-3522: Improve the README
b2b05c3 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
AVRO-3522: Give better names to some methods
22b1a2a 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
AVRO-3522: Make LOG_MESSAGES module-private
021db19 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@github-actions github-actions bot added the Rust label May 17, 2022
martin-g added 2 commits May 17, 2022 21:56
@martin-g
AVRO-3522: Add ASL2 to the new files
3578c15 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
AVRO-3522: Use pretty_assertions for better diffs when assertions fail
9e54be7 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@jklamer
Copy link
Contributor

jklamer commented May 18, 2022

nice! Ill have to pull this locally and break some stuff!

@martin-g
Copy link
Member Author

martin-g commented May 18, 2022

To test it add a panic!() somewhere in the code or intentionally break some assert_eq!() call, or change the value of RUST_LOG.

@martin-g martin-g merged commit 2c13cd7 into master May 22, 2022
martin-g added a commit that referenced this pull request May 22, 2022
@martin-g
AVRO-3522: Better logging in tests (#1690)
cf7f949 
* AVRO-3522: Use ctor crate to setup/teardown tests

Use TestLogger for all tests. Now it delegates to env_logger too

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* AVRO-3522: Improve the README

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* AVRO-3522: Give better names to some methods

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* AVRO-3522: Make LOG_MESSAGES module-private

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* AVRO-3522: Add ASL2 to the new files

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* AVRO-3522: Use pretty_assertions for better diffs when assertions fail

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
(cherry picked from commit 2c13cd7)
@martin-g martin-g deleted the avro-3522-better-logging-in-tests branch May 22, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martin-g @jklamer