AVRO-1931: Reader is now compatible if able to read all branches of u…#199
AVRO-1931: Reader is now compatible if able to read all branches of u…#199epkanol wants to merge 1 commit intoapache:masterfrom
Conversation
|
New try, this time forking apache/avro on github |
|
+1. |
|
@rdblue we are also looking to have these patches in Avro. Appreciate if committers can take a look. |
| @@ -0,0 +1,268 @@ | |||
| package org.apache.avro; | |||
There was a problem hiding this comment.
Missing headers for the apache license
There was a problem hiding this comment.
Added ASL (copied from other test class). Updated same commit (amend, push -f)
There was a problem hiding this comment.
@harshach my branch (actually, the same commit) was updated 10th of April, don't know what else to do. Waiting for your review and acceptance/merge into master.
The Apache License was added to my new file, and the reason the // is there in the file is in order to preserve formatting across IDEs (My Eclipse has been acting erratically lately - Neon upgrade issue)
|
|
||
| @Rule | ||
| public ExpectedException expectedException = ExpectedException.none(); | ||
| // |
There was a problem hiding this comment.
not sure why // present on multiple lines.
|
@epkanol can you please addres @spacharya review. Thanks. |
|
@harshach thanks for reviewing this! What Author string would you like used for a signed-off-by line? |
4 participants
…nion