AVRO-3715 Make the build work again.#2106
Merged
nielsbasjes merged 2 commits intoapache:masterfrom Feb 17, 2023
Merged
Conversation
martin-g
reviewed
Feb 17, 2023
nielsbasjes
force-pushed
the
AVRO-3715-MoreFixes
branch
from
5693a02 to
3a83631
Compare
Contributor
Author
|
@martin-g Can you please check if the type fix I did is correct. My python skills are too limited for me to know for sure if this is the correct way. |
martin-g
approved these changes
Feb 17, 2023
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
I am not a Python person too but it looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix python formatting problems.