AVRO-2069: Use primitive fields in generated getters & setters in Java code #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a code Fix broken unit tests in TestSpecificCompilerTool
Sync up with origin repository
…a code Fix broken unit tests in TestSpecificCompilerTool after migrating to org.junit.Test
busbey
approved these changes
Sep 15, 2017
Contributor
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
let's get this in for 1.9. if desired we can have a follow-on to make a backwards compatible version for 1.7/1.8 folks.
Contributor
|
This can be an option at generation time for those that don't want to break compatibility (defaulting to the old way prior to 1.9). |
Was this option ever implemented? This change causes a lot of compatibility issues when upgrading from 1.8.2. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for primitive types (such as int, long, etc) generated getters and setters return and accept java.lang.* boxed (while fields actually holds primitive values). This is inefeccient and produces code boilerplate.
The only issue with this approach that it breaks source compatibility with previously generated code.