AVRO-2165 Change namespace definitions in C++. Use nested namespaces instead of… #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… colon separated.
Contributor
|
Thank you for the improvement. |
thiru-mg
changed the title
Contributor
Author
|
So I have created an account on apache jira (kwallner), but I was not able to assign the ticket. Looks like I'm lacking the permission to assign for tickets. |
Contributor
|
I just added you as an Avro Contributor in Jira so you should be able to assign the issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace definitions using colons are supported since C++17 (http://en.cppreference.com/w/cpp/language/namespace).
This fix makes the library usable for C++11 and avoids compiler error "Compiler Error C2429" (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2429).