AVRO-1635 C++ schema aware encoders throw tr1::bad_weak_ptr exception for recursive schema #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wmatthews-google
commented
Mar 20, 2018
wmatthews-google
commented
- Use indirect symbols to "own" the production needed for records (so that weak_ptrs have something to point to)
- Use a stack instead of a counter for the number of items in a repeated symbol
- A handful of tests.
thiru-mg
changed the title
Contributor
Author
|
Hi! I wanted to follow up on this. I'd be happy to restructure the code if that'd help get this in. Please let me know! |
- Use indirect symbols to "own" the production needed for records (so that weak_ptrs have something to point to) - Use a stack instead of a counter for the number of items in a repeated symbol - A handful of tests.
wmatthews-google
force-pushed
the
fix-issue-1635
branch
from
b7c9e27 to
390a854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.