AVRO-2208 Unneeded OSGi import generated for Guava dependency #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are shaded into the final jar therefore the OSGi bundle does not need to import these packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes from Guava used by Avro are shaded into the final jar, however the OSGi imports are calculated before shading, resulting in a com.google.common* dependency declared in Import-Package manifest header. As a consequence in an OSGi environment one has to install a version of Guava even though that version will not be used by Avro.
By adding !com.google.common* to the Import-Package directive of the maven-bundle-plugin the package(s) of Guava will no longer be declared on the Import-Package of the Avro OSGi bundle.