AVRO-XXXX: FastReaderBuilder throws ClassCastException for schemas with java-class attribute #3616
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'd be happy to try and propose a fix as well but I'm not great at Java |
kevinburkesegment
force-pushed
the
reproduce-issue
branch
from
c686468 to
8d01043
Compare
…th java-class attribute
When using GenericDatumReader with schemas containing "java-class"
attributes on string fields (e.g., java.math.BigDecimal),
FastReaderBuilder throws:
ClassCastException: Utf8 cannot be cast to String
The bug is in getTransformingStringReader() which casts the result of
stringReader.read() directly to String, but GenericData returns Utf8.
This commit adds a failing test to reproduce the issue.
kevinburkesegment
force-pushed
the
reproduce-issue
branch
from
8d01043 to
f7bced3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO JIRA instance ticket number will be filed as soon as my request to create a JIRA account is granted.
What is the purpose of the change
When using GenericDatumReader with schemas containing "java-class" attributes on string fields (e.g., java.math.BigDecimal), FastReaderBuilder throws:
The bug is in getTransformingStringReader() which casts the result of stringReader.read() directly to String, but GenericData returns Utf8.
This commit adds a failing test to reproduce the issue.
Verifying this change
Run the test suite.
Documentation