AVRO-4182: Avoid ANTLR parsing edge cases#3756
Merged
Merged
Conversation
In some cases, enter and exit rules are not called in pairs. Apparently, this is by design. This fix adds a test that the fix does indeed work (it tests an exception, as the error does not show up with a duplicated definition). Note: this change keeps the entire parse tree in memory during parsing, and allows it to be collected directly afterwards.
nandorKollar
reviewed
May 4, 2026
| parser.removeErrorListeners(); | ||
| parser.addErrorListener(SIMPLE_AVRO_ERROR_LISTENER); | ||
| parser.addParseListener(parseListener); | ||
| // parser.addParseListener(parseListener); |
Contributor
There was a problem hiding this comment.
I think you can remove this line.
opwvhk
added a commit
that referenced
this pull request
May 15, 2026
In some cases, enter and exit rules are not called in pairs while parsing. Apparently, this is by design. This fix adds a test that the fix does indeed work (it tests an exception, as the error does not show up with a duplicated definition). Note: this change keeps the entire parse tree in memory during parsing, and allows it to be collected directly afterwards. (cherry picked from commit 34bdcf9)
Contributor
Author
|
Cherry-picked to 1.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In some cases, enter and exit rules are not called in pairs. Apparently, this is by design. This fix adds a test that the fix does indeed work (it tests an exception, as the error does not show up with a duplicated definition).
Note: this change keeps the entire parse tree in memory during parsing, and allows it to be collected directly afterwards.
This PR fixes the bug reported as AVRO-4182.
Verifying this change
This change adds a test:
org.apache.avro.idl.TestIdlReader#testErrorDuplicateNamedType()Documentation
yes/ no)docs / JavaDocs / not documented)