Skip to content

MINOR: [C++] Add missing header <type_traits>#3808

Open
wgtmac wants to merge 1 commit into
apache:mainfrom
wgtmac:fix_missing_header
Open

MINOR: [C++] Add missing header <type_traits>#3808
wgtmac wants to merge 1 commit into
apache:mainfrom
wgtmac:fix_missing_header

Conversation

@wgtmac
Copy link
Copy Markdown
Member

@wgtmac wgtmac commented Jun 6, 2026

What is the purpose of the change

Fix avro-cpp builds with C++23 by including <type_traits> directly in Buffer.hh, which uses std::is_fundamental.

Verifying this change

This change is already covered by existing tests, such as the avro-cpp C++23 build and existing C++ test suite.

  • Built avrocpp_s with -DCMAKE_CXX_STANDARD=23
  • Ran the avro-cpp C++ test suite: 13/13 tests passed

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@github-actions github-actions Bot added the C++ Pull Requests for C++ binding label Jun 6, 2026
@wgtmac
Copy link
Copy Markdown
Member Author

wgtmac commented Jun 6, 2026

I tried to bump Avro-cpp in iceberg-cpp (which uses C++23) but failed due to a missing header. Could you help take a look? @martin-g @Fokko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ Pull Requests for C++ binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants