AVRO-1692: Allow multiple logical types for a Java class.#39
Closed
rdblue wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Aren't these two changes breaking backwards compatibility? Or is this only 1.8?
Contributor
Author
There was a problem hiding this comment.
This hasn't been included in a release yet, so it isn't breaking compatibility. I think it was originally an oversight on my part to make them public.
Contributor
There was a problem hiding this comment.
wfm. sorry for not checking for an actual release.
rdblue
force-pushed
the
AVRO-1692-logical-type-fix
branch
from
a0ed592 to
cbb833b
Compare
This changes the class to conversion lookup to store multiple conversions and choose based on the logical type name. This still assumes that only one conversion is registered for each logical type.
This adds TestCircularReferences, which demonstrates how to use logical types to implement circular references and tests using multiple logical types with the same class.
rdblue
force-pushed
the
AVRO-1692-logical-type-fix
branch
from
cbb833b to
70b437e
Compare
Contributor
Author
Contributor
Author
|
Merged by Tom. |
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the class to conversion lookup to store multiple
conversions and choose based on the logical type name. This still
assumes that only one conversion is registered for each logical type.