AVRO-2357: Allow generic types in reflect protos#490
Merged
Conversation
Member
|
We introduced automatic code formatting. For more info see the "How to contribute" page. This probably affected this PR can you please rebase it. |
Contributor
Author
|
@iemejia thanks for the heads up. I just rebased and applied spotless formatting. |
Fokko
reviewed
Mar 29, 2019
| Map<String, Schema> names = new LinkedHashMap<>(); | ||
| Map<String, Message> messages = protocol.getMessages(); | ||
| Map<TypeVariable<?>, Type> genericTypeVariableMap = ReflectionUtil.resolveTypeVariables(iface); | ||
| for (Method method : iface.getMethods()) |
Contributor
There was a problem hiding this comment.
Not part of the PR, but can we add brackets here, looks awkward.
Fokko
approved these changes
Mar 29, 2019
Adds support for generic types in ReflectData for Protocols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generic types in ReflectData for Protocols.
I also took the liberty of cleaning up the iteration over Parameters; the multi-dimensional array style is no longer really necessary with the new methods on Parameter.
https://issues.apache.org/jira/browse/AVRO-2357