WIP: AVRO-2335 Remove Joda Time library#495
Conversation
Fokko
force-pushed
the
fd-remove-joda-time
branch
from
8bb1d53 to
a50962a
Compare
|
Thanks, @nandorKollar I was still working on it :) Ready for review now! 👍 |
Fokko
changed the title
|
This likely needs to be slit into two parts... One part is changing the various test classes to using and expecting the jsr310 types. That would definitely help make sure the jsr310 stuff is fully working and is something I would support getting in for 1.9. The other part is the actual removal of joda-time altogether. As mentioned on the JIRA, I'm completely against the complete removal of joda-time for 1.9. 1.9 needs to continue to allow joda-time to allow a quicker migration. |
|
Thanks for the feedback @dkulp I've set this to 1.10, and won't merge this until 1.9 has been released. I fully agree with you that we can't move this into 1.9. Having jsr310 as a default 1.9 is already a breaking change. I will test in the upcoming days to get Divolte working with Avro 1.9 snapshot. |
|
Big +1 on moving this to 1.10, otherwise adoption will suffer and we really need other projects to catch on Avro in particular for security issues in the dependencies that are not needed anymore in 1.9. |
| new String(fileInDefaultEncoding), equalTo(new String(fileInDifferentEncoding, differentEncoding))); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
There are several test cases deleted, are they covered somewhere else? So far I just took a brief look at this PR, so I might have more comments later, but the changes on this test instantly caught my eyes. I'm not sure if these cases give proper coverage, but would it provide value if we wouldn't drop them, but adjust the asserts to Java date/time API instead?
There was a problem hiding this comment.
Lets park this one after the 1.9 release.
Fokko
changed the title
|
Gentle ping @Fokko, it seems this PR need a rebase to master. Are you still working on this? |
|
@nandorKollar I'm happy to pick this up, but right now I'm extremely limited on time, feel free to take it over if you feel like it. |
|
I need to revisit this later. |
4 participants
No description provided.