Skip to content

AVRO-2383: NPE during Schema.applyAliases#510

Merged
Fokko merged 1 commit intoapache:masterfrom
rocketraman:AVRO-2383
Apr 29, 2019
Merged

AVRO-2383: NPE during Schema.applyAliases#510
Fokko merged 1 commit intoapache:masterfrom
rocketraman:AVRO-2383

Conversation

@rocketraman
Copy link
Member

@rocketraman rocketraman commented Apr 28, 2019 •
edited by Fokko
Loading

@probot-autolabeler probot-autolabeler bot added build C# Java Pull Requests for Java binding labels Apr 28, 2019
@rocketraman rocketraman reopened this Apr 28, 2019
@rocketraman rocketraman changed the title Fix AVRO-2383 AVRO-2383: NPE during Schema.applyAliases Apr 28, 2019
Fokko
Fokko reviewed Apr 28, 2019
View reviewed changes
Fokko
Fokko reviewed Apr 28, 2019
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rocketraman for fixing this. Can you remove the println's form the tests?

ivangreene
ivangreene reviewed Apr 28, 2019
View reviewed changes
@rocketraman rocketraman force-pushed the AVRO-2383 branch 2 times, most recently from 1d4ac34 to 76818ca Compare April 28, 2019 18:42
@rocketraman
Copy link
Member Author

rocketraman commented Apr 28, 2019

Comments addressed, thanks.

@rocketraman
Copy link
Member Author

rocketraman commented Apr 28, 2019

NOTE: I do have build failures locally because my generated code for tests throws exceptions that the test cases don't declare... not sure why that is but it did make things a bit more difficult than they should have been.

Fokko
Fokko approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @rocketraman

On an unrelated note, not sure why the C# tag is here @iemejia

@Fokko Fokko merged commit 196777c into apache:master Apr 29, 2019
Fokko pushed a commit that referenced this pull request Apr 29, 2019
@rocketraman @Fokko
AVRO-2383: NPE during Schema.applyAliases (#510)
8dbe05a 
(cherry picked from commit 196777c)
@rocketraman
Copy link
Member Author

rocketraman commented Apr 29, 2019

The tag got automatically added because I initially created the branch on top of branch-1.9 but GitHub created the pull with a base of master. So a few commits on master got added into this pull request, and those caused the c# tag to be added.I then rebased the branch on master, but the change in included commits didn't alter the tag list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

+1 more reviewer

@ivangreene ivangreene ivangreene left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build C# Java Pull Requests for Java binding

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rocketraman @Fokko @ivangreene