Skip to content

AVRO-2453: Implement interop test for the C bindings#583

Merged
dkulp merged 1 commit intoapache:masterfrom
sekikn:AVRO-2453
May 21, 2020
Merged

AVRO-2453: Implement interop test for the C bindings#583
dkulp merged 1 commit intoapache:masterfrom
sekikn:AVRO-2453

Conversation

@sekikn
Copy link
Copy Markdown
Contributor

@sekikn sekikn commented Jul 10, 2019

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

This PR is a fix for test_interop_data.c.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler bot added the C label Jul 10, 2019
@dkulp dkulp merged commit 207035a into apache:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants