Skip to content

AVRO-2551:Changed datum API to value API in examples\quickstop#641

Merged
dkulp merged 1 commit intoapache:masterfrom
zeshuai007:AVRO-2551
May 21, 2020
Merged

AVRO-2551:Changed datum API to value API in examples\quickstop#641
dkulp merged 1 commit intoapache:masterfrom
zeshuai007:AVRO-2551

Conversation

@zeshuai007
Copy link
Copy Markdown
Member

@zeshuai007 zeshuai007 commented Sep 6, 2019

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler bot added the C label Sep 6, 2019
@zeshuai007
Copy link
Copy Markdown
Member Author

@dcreager Do you have a spare moment to review this?

Copy link
Copy Markdown
Contributor

@dcreager dcreager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It's been quite awhile since I've looked at this API, but broadly speaking it looks right.

It also looks like this file is run as a test, too, so if tests are still passing that's a good indication that you got the migration right!

@zeshuai007
Copy link
Copy Markdown
Member Author

@Fokko Can this PR be merged?

@dkulp dkulp merged commit 88538e9 into apache:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants