Skip to content

Conversation

@kojiromike
Copy link
Contributor

Jira

  • My PR addresses AVRO-2593 and references it in the PR title.
  • My PR does not introduce any dependencies.

Tests

  • My PR is a refactor of an existing test. It does not change primary functionality.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • My PR does not add functionality and does not require any changes to documentation.

@kojiromike
Copy link
Contributor Author

I can't seem to reproduce the JAVA=11 test failure locally. When I run in a Java 11 environment locally the tests pass. :/

@kojiromike
Copy link
Contributor Author

Will revisit in AVRO-2603.

@kojiromike kojiromike closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant