AVRO-2639: add option to write Optional only when fields are nullable#726
Closed
ecopoesis wants to merge 1 commit intoapache:masterfrom
Closed
AVRO-2639: add option to write Optional only when fields are nullable#726ecopoesis wants to merge 1 commit intoapache:masterfrom
ecopoesis wants to merge 1 commit intoapache:masterfrom
Conversation
Adds a new option to SpecificCompiler: gettersReturnOptionalOnlyForNullable. When enabled, and when gettersReturnOptional is also enabled, getters will only return Optional when the underlying field in nullable. This also improves the documentation for gettersReturnOptional and createOptionalGetters, adding examples to both.
Contributor
|
Nice! While you are here, I think it is a good idea to tweak it further: Use OptionalInt/OptionalLong/OptionalDouble for corresponding primitive types. |
|
This looks like it implements the same functionality as #817, but that implementation's velocity template seemed a bit cleaner at first glance. |
|
Would be nice to have an update on this important feature |
Fokko
approved these changes
May 3, 2020
Contributor
|
Thanks for the PR, I like this one. Would be much nicer if we could use the primitive types, as @kan-izh suggests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Tests
My PR adds the following unit tests OR does not need testing for this extremely good reason:
testPojoWithOptionalOnlyWhenNullableCreatedTurnedOntestPojoWithOptionalOnlyWhenNullableCreatedTurnedOnAndGettersReturnOptionalTurnedOffCommits
Documentation