Skip to content

AVRO-2657: Fix Python Interop Data Generator#746

Closed
kojiromike wants to merge 1 commit intoapache:masterfrom
kojiromike:AVRO-2657/py-interop
Closed

AVRO-2657: Fix Python Interop Data Generator#746
kojiromike wants to merge 1 commit intoapache:masterfrom
kojiromike:AVRO-2657/py-interop

Conversation

@kojiromike
Copy link
Copy Markdown
Contributor

Jira

  • My PR addresses AVRO-2657
  • ...and references it in the PR title.
  • ...adds no dependencies.

Tests

  • Fixes where build.sh puts the interop test data generated by Python.

Commits

Documentation

  • N/A

@kojiromike
Copy link
Copy Markdown
Contributor Author

@sekikn Please review.

@kojiromike kojiromike self-assigned this Dec 17, 2019
@sekikn
Copy link
Copy Markdown
Contributor

sekikn commented Dec 17, 2019

Looks good for the interop-data-generate function :) In addition, interop-data-test should be also fixed so that it can refer to the files generated by other language bindings.

@kojiromike
Copy link
Copy Markdown
Contributor Author

I've decided to roll this into #742 because I want to use tox itself to make the interop avro files available in the tox virtualenvs for each python implementation.

@kojiromike kojiromike closed this Dec 18, 2019
@kojiromike kojiromike deleted the AVRO-2657/py-interop branch December 18, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants