AVRO-2763:Resource leak:'<unassigned Closeable value>' is never closed

[zeshuai007]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
  • https://issues.apache.org/jira/browse/AVRO-2763
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain Javadoc that explain what it does

[Fokko]

Can we switch to the try-with-resource pattern? That gives a better example :-)

[zeshuai007]

OK, I have changed all to try-with-resource. Thanks for the review @Fokko !

[anhldbk]

@zeshuai007 @Fokko Hi guys. A naive question: Would you please tell me how to properly open a Pull Request for Apache Avro? I see not so much discussion on your issue: https://issues.apache.org/jira/browse/AVRO-2763. Is there any guideline?

[Fokko]

No worries @anhldbk. Here's a guide: https://opensource.com/article/19/7/create-pull-request-github Please let me know if there are any further questions. You have to fork the repository, and then you can create a PR on your own fork, from which you can create a PR.

[anhldbk]

@Fokko Still I think we need discussions with maintainers first via Jira issues. Would you please have a look at my opening issue. Thank you in advance.

[anhldbk]

@Fokko Travis have failed. I checked the logs and I think we have problems with service quality of Travis

[Fokko]

@anhldbk can you rebase onto master?

[zeshuai007]

@Fokko
Sure, it has been rebase.