Skip to content

AVRO-2765: Py3 Support: Use open(), not file()#836

Merged
Fokko merged 1 commit intoapache:masterfrom
kojiromike:AVRO-2765/fileopen
Apr 22, 2020
Merged

AVRO-2765: Py3 Support: Use open(), not file()#836
Fokko merged 1 commit intoapache:masterfrom
kojiromike:AVRO-2765/fileopen

Conversation

@kojiromike
Copy link
Contributor

@kojiromike kojiromike commented Mar 1, 2020

Jira

  • My PR addresses AVRO-2765
  • It references it in the title.
  • No dependencies.

Tests

  • Needs a regression test

Commits

Documentation

  • No feature changes, no additional documentation needed.

@Fokko
Copy link
Contributor

Fokko commented Mar 2, 2020

Sad CI, we're unable to import the ContextManager module:

+ ./build.sh lint test
GLOB sdist-make: /home/travis/build/apache/avro/lang/py/setup.py
lint create: /home/travis/build/apache/avro/lang/py/.tox/lint
ERROR: invocation failed (exit code 1), logfile: /home/travis/build/apache/avro/lang/py/.tox/lint/log/lint-0.log
================================== log start ===================================
ImportError: cannot import name 'ContextManager'
=================================== log end ====================================
ERROR: InvocationError for command /usr/bin/python3 -m virtualenv --no-download --python /usr/bin/python3 lint (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   lint: InvocationError for command /usr/bin/python3 -m virtualenv --no-download --python /usr/bin/python3 lint (exited with code 1)
Total Elapsed time:  21m 22s

@kojiromike
Copy link
Contributor Author

Huh, I haven't been able to reproduce that problem locally. Hopefully it was just a fluke.

@kojiromike kojiromike self-assigned this Apr 22, 2020
@Fokko Fokko merged commit 97c2aeb into apache:master Apr 22, 2020
@Fokko
Copy link
Contributor

Fokko commented Apr 22, 2020

Thanks again @kojiromike

@kojiromike kojiromike deleted the AVRO-2765/fileopen branch April 22, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants