Skip to content

AVRO-2819:Add BigInteger and BigDecimal support for JacksonUtils#859

Merged
Fokko merged 1 commit intoapache:masterfrom
zeshuai007:jackson-util
May 3, 2020
Merged

AVRO-2819:Add BigInteger and BigDecimal support for JacksonUtils#859
Fokko merged 1 commit intoapache:masterfrom
zeshuai007:jackson-util

Conversation

@zeshuai007
Copy link
Member

@zeshuai007 zeshuai007 commented Apr 16, 2020

this change is relatively small, so I didn't submit a issue in jira.
It allows JacksonUtils.toJsonNode(Object datum) receive type BigInteger and BigDecimal.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler bot added the Java Pull Requests for Java binding label Apr 16, 2020
@zeshuai007
Copy link
Member Author

Hi,

The CI failure of this PR has nothing to do with the modification of the lang/java package.
Error message:

Resolving dependencies...
rubocop-0.82.0 requires ruby version >= 2.4.0, which is incompatible with the
current version, ruby 2.3.3p222
The command '/bin/sh -c bundle install --gemfile=/tmp/Gemfile' returned a non-zero code: 5

@Fokko
Copy link
Contributor

Fokko commented Apr 26, 2020

@zeshuai007 This looks good, can you create a ticket in Jira? We use this to generate changelogs.

@zeshuai007 zeshuai007 changed the title Add BigInteger and BigDecimal support for JacksonUtils AVRO-2819:Add BigInteger and BigDecimal support for JacksonUtils Apr 27, 2020
@zeshuai007
Copy link
Member Author

Thanks for the review and approval, a ticket has been created in Jira.

@Fokko
Copy link
Contributor

Fokko commented May 3, 2020

Thanks @zeshuai007

@Fokko Fokko merged commit 07fd336 into apache:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants