Skip to content

AVRO-2844:Avro-js can't parse default value {}#893

Merged
dkulp merged 1 commit intoapache:masterfrom
zeshuai007:AVRO-2844
May 26, 2020
Merged

AVRO-2844:Avro-js can't parse default value {}#893
dkulp merged 1 commit intoapache:masterfrom
zeshuai007:AVRO-2844

Conversation

@zeshuai007
Copy link
Member

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@dkulp dkulp merged commit ad63705 into apache:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments