Skip to content

AVRO-2757: Avoid dollar signs when reflecting Java#914

Merged
RyanSkraba merged 1 commit into
apache:masterfrom
RyanSkraba:AVRO-2757-reflect-dollar
Jul 2, 2020
Merged

AVRO-2757: Avoid dollar signs when reflecting Java#914
RyanSkraba merged 1 commit into
apache:masterfrom
RyanSkraba:AVRO-2757-reflect-dollar

Conversation

@RyanSkraba
Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler Bot added the Java Pull Requests for Java binding label Jun 8, 2020
@RyanSkraba RyanSkraba merged commit 2c7b9af into apache:master Jul 2, 2020
@RyanSkraba RyanSkraba deleted the AVRO-2757-reflect-dollar branch July 2, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants