Skip to content

AVRO-1664: Fix RAT exclusions for PHP vendor#916

Merged
iemejia merged 1 commit into
apache:masterfrom
RyanSkraba:AVRO-1664-fix-rat
Jun 9, 2020
Merged

AVRO-1664: Fix RAT exclusions for PHP vendor#916
iemejia merged 1 commit into
apache:masterfrom
RyanSkraba:AVRO-1664-fix-rat

Conversation

@RyanSkraba
Copy link
Copy Markdown
Contributor

Add the RAT exclusions for downloaded PHP libraries that are not delivered with Avro.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Copy link
Copy Markdown
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 5ac4553 into apache:master Jun 9, 2020
@RyanSkraba RyanSkraba deleted the AVRO-1664-fix-rat branch June 9, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants