Skip to content

AVRO-1461: Distribute Perl API on CPAN#923

Merged
iemejia merged 1 commit intoapache:masterfrom
sekikn:AVRO-1461
Jul 2, 2020
Merged

AVRO-1461: Distribute Perl API on CPAN#923
iemejia merged 1 commit intoapache:masterfrom
sekikn:AVRO-1461

Conversation

@sekikn
Copy link
Contributor

@sekikn sekikn commented Jul 2, 2020

Fix Makefile.PL so that PAUSE can identify Avro packages and corresponding files

cc @iemejia @RyanSkraba

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional test, since it's a fix for a build script. I ran ./build.sh dist and uploaded the generated Perl distribution tarball to PAUSE, and confirmed that it was published via CPAN successfully.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Fix Makefile.PL so that PAUSE can identify Avro packages and corresponding files
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 98c29fb into apache:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants