AVRO-2471: Generate specific conversions from LogicalType#938
Merged
iemejia merged 2 commits intoapache:masterfrom Mar 4, 2021
Merged
AVRO-2471: Generate specific conversions from LogicalType#938iemejia merged 2 commits intoapache:masterfrom
iemejia merged 2 commits intoapache:masterfrom
Conversation
RyanSkraba
commented
Jul 31, 2020
| @@ -287,15 +287,52 @@ public void addCustomConversion(Class<?> conversionClass) { | |||
| } | |||
|
|
|||
| public Collection<String> getUsedConversionClasses(Schema schema) { | |||
Contributor
Author
There was a problem hiding this comment.
There's some dead code as a consequence of this change: getClassNamesOfPrimitiveFields -- I'm taking a look.
I'm also thinking that if the user explicitly called addCustomConversion, it should be considered "used" and included no matter what, but that currently isn't the case.
3ee0d02 to
35491a6
Compare
35491a6 to
b32ef59
Compare
iemejia
approved these changes
Mar 4, 2021
Member
iemejia
left a comment
There was a problem hiding this comment.
LGTM Thanks for fixing this Ryan using the registered logical types seems like the most reasonable approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of collecting the types of primitive datum that appear in a generated class, use the model to find the appropriate Conversion<?> instances that should be used for logical types.
Jira
Tests
Commits
Documentation