Skip to content

AVRO-2945: Add CPAN trademark clarification.#975

Merged
iemejia merged 2 commits intoapache:masterfrom
RyanSkraba:AVRO-2945-cpan-trademark
Nov 12, 2020
Merged

AVRO-2945: Add CPAN trademark clarification.#975
iemejia merged 2 commits intoapache:masterfrom
RyanSkraba:AVRO-2945-cpan-trademark

Conversation

@RyanSkraba
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Documentation only

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the Perl label Nov 6, 2020
@RyanSkraba
Copy link
Contributor Author

@justinmclean Could you verify this is an alright wording? Regarding this thread and this artifact on CPAN.

@justinmclean
Copy link
Member

justinmclean commented Nov 8, 2020 via email

@RyanSkraba RyanSkraba force-pushed the AVRO-2945-cpan-trademark branch from 1bfb7b3 to bf6581a Compare November 10, 2020 16:33
@iemejia iemejia self-requested a review November 12, 2020 14:52
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 5ebede6 into apache:master Nov 12, 2020
@RyanSkraba
Copy link
Contributor Author

Cherry-picked to branch-1.10

@RyanSkraba RyanSkraba deleted the AVRO-2945-cpan-trademark branch November 12, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants