Skip to content

AVRO-2954 Make JAVA org.apache.avro.generic.GenericContainer Serializable#976

Open
Karl-WangSK wants to merge 1 commit intoapache:mainfrom
Karl-WangSK:AVRO-2954
Open

AVRO-2954 Make JAVA org.apache.avro.generic.GenericContainer Serializable#976
Karl-WangSK wants to merge 1 commit intoapache:mainfrom
Karl-WangSK:AVRO-2954

Conversation

@Karl-WangSK
Copy link

@Karl-WangSK Karl-WangSK commented Nov 6, 2020

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the Java Pull Requests for Java binding label Nov 6, 2020
@Karl-WangSK
Copy link
Author

Karl-WangSK commented Nov 6, 2020

surprise. test failed , it has nothing to do with this pr tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant