Skip to content

Add JingsongLee as committer#266

Closed
JingsongLi wants to merge 2 commits intoapache:asf-sitefrom
JingsongLi:new_committer
Closed

Add JingsongLee as committer#266
JingsongLi wants to merge 2 commits intoapache:asf-sitefrom
JingsongLi:new_committer

Conversation

@JingsongLi
Copy link

No description provided.

@JingsongLi
Copy link
Author

R: @davorbonaci

@asfgit
Copy link

asfgit commented Jul 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/547/

Jenkins built the site at commit id 277078a with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@davorbonaci davorbonaci self-requested a review July 6, 2017 17:39
@davorbonaci davorbonaci self-assigned this Jul 6, 2017
@kennknowles
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


content/contribute/team/index.html, line 377 at r1 (raw file):

        </tr>

        <tr>

Our process for the site is to generate the content separately from the PR, so you should drop this file from the PR.


src/_beam_team/team.md, line 149 at r1 (raw file):

    roles: committer
    time_zone: "+2"
  - name: Jingsong Lee

Just to keep things in alphabetical order, you should be after Aljoscha.


Comments from Reviewable

@kennknowles
Copy link
Member

(That was a test of Reviewable - it looks like it doesn't post the comments as a GitHub review)

@JingsongLi
Copy link
Author

Thanks @kennknowles

@asfgit
Copy link

asfgit commented Jul 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/550/

Jenkins built the site at commit id 1f82221 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@davorbonaci
Copy link
Member

@asfgit merge

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @JingsongLi.

@asfgit asfgit closed this in 09c53eb Jul 9, 2017
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants