Skip to content

Friendlier contribution guide; link to starter tasks#426

Closed
kennknowles wants to merge 1 commit intoapache:asf-sitefrom
kennknowles:contribution-guide
Closed

Friendlier contribution guide; link to starter tasks#426
kennknowles wants to merge 1 commit intoapache:asf-sitefrom
kennknowles:contribution-guide

Conversation

@kennknowles
Copy link
Member

This is sort of a minimal change to the contribution guide to make the opening lines a bit friendlier and more concise. I also wanted to link directly to a saved JIRA search for starter tasks.

There's lots more to do to make the guide more concise and welcoming.

Copy link

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the link below. Thanks!

Most importantly, if you have an idea of how to contribute, then do it!

For a list of open starter tasks, check
[https://s.apache.org/beam-starter-tasks](https://s.apache.org/beam-starter-tasks).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't seem to be working for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I don't really quite understand what I have messed up in the markdown.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown looks fine to me, but I'm getting "The requested filter doesn't exist or is private. Try logging in." when going to the link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the same UI fail I've had every time - select who to share it with, click "Save". Forgot to click "+Add" first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try now?

@kennknowles
Copy link
Member Author

retest this please

@robertwb
Copy link

Looks good now. The tests are failing due to #429 (and I don't have write permission to merge it.)

@kennknowles
Copy link
Member Author

retest this please

@kennknowles
Copy link
Member Author

@robertwb but you should have write permission - it is being a committer + gitbox. Or did we block everyone other than mergebot?

@kennknowles
Copy link
Member Author

@asfgit merge

@melap
Copy link

melap commented Apr 25, 2018

I don't know the details of permissions, but I amm able to manually merge so it must not be just locked down to just mergebot.

@asfgit asfgit closed this in da98d3c Apr 25, 2018
@robertwb
Copy link

Somehow this repo is configured differently than the beam one. Or perhaps it's due to being a special branch--I get a link to https://help.github.com/articles/about-protected-branches/ instead of the merge button.

@kennknowles
Copy link
Member Author

Oh, yeah, you have write access to gitbox but not GitHub. And you do have to manually generate the content when you manually merge. The asf-site branch is directly mirrored to deploy the site. We could do a medium lift and move src development to master and the built site on asf-site, with hooks to build. Would enable simpler flow. I don't have bandwidth to drive such a change.

robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants