-
Notifications
You must be signed in to change notification settings - Fork 123
Streamline the Contribute section a bit #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77de036 to
a4f2e5c
Compare
| A great way to contribute is to join an existing effort. There are many | ||
| works in progress, some on branches because they are very incomplete. | ||
|
|
||
| ### Portability Framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@herohde @bsidhom This is a fairly abbreviated link, but I thought it was the most important work-in-progress to highlight. It might be nice to break it out into efforts for each SDK and runner. Or maybe that should be just part of the linked doc. Anyhow, take a look at http://apache-beam-website-pull-requests.storage.googleapis.com/438/contribute/index.html#works-in-progress and see what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If at all, you could reference BEAM-2889 under a new portable Flink runner section. I'm not sure how much sense it makes to add directly to the linked doc because that already contains a reference to the umbrella "wordcount runs everywhere" bug (BEAM-2896).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think mentioning the Flink runner more prominently both here and on the portability page would be great. I also wanted to reference the progress sheet under status, so it might be a good context to call out Flink.
I don't think we should make it a new section, because it's not a new runner in the same way the others are. But I don't feel very strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I prevail upon one of you two to follow up this PR or issue a PR to my PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do a followup PR.
|
retest this please |
|
Ah, the test is failure because of Google's choice to eliminate "research" and only have "AI". A bit of an awkward moniker for FlumeJava. |
d264be5 to
b0c16fd
Compare
b0c16fd to
4284b6a
Compare
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
melap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, much simpler!
|
not sure how to solve that test failure though |
|
retest this please |
|
I believe the problem is with the certs for |
|
OTOH I can't repro it on my laptop nor do browsers warn as far as I can tell. |
|
Ah, CA issue with the Jenkins worker. |
|
Pushed a commit to sickbay that domain for now. Following up separately. |
Rakefile
Outdated
| :check_html => true, | ||
| :file_ignore => [/javadoc/, /v2/, /pydoc/], | ||
| :url_ignore => [/jstorm.io/, /datatorrent.com/], | ||
| :url_ignore => [/jstorm.io/, /datatorrent.com/, /ai.google/], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you cite https://issues.apache.org/jira/browse/INFRA-16527 for removal of ai.google?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
aeaa619 to
25a50fe
Compare
|
@asfgit merge |
|
Error: PR failed in verification; check the Jenkins job for more information. |
|
@asfgit merge |
This does a few things:
http://apache-beam-website-pull-requests.storage.googleapis.com/438/contribute/index.html