Skip to content

Conversation

@kennknowles
Copy link
Member

@kennknowles kennknowles commented May 11, 2018

This does a few things:

  • Reference external guides rather than have our guide explain git and GitHub
  • Make things more concise and less prescriptive
  • Merge as much as possible into the main contribution guide

http://apache-beam-website-pull-requests.storage.googleapis.com/438/contribute/index.html

@kennknowles kennknowles requested a review from melap May 11, 2018 23:01
@kennknowles kennknowles force-pushed the contribution-guide branch from 77de036 to a4f2e5c Compare May 11, 2018 23:10
A great way to contribute is to join an existing effort. There are many
works in progress, some on branches because they are very incomplete.

### Portability Framework
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herohde @bsidhom This is a fairly abbreviated link, but I thought it was the most important work-in-progress to highlight. It might be nice to break it out into efforts for each SDK and runner. Or maybe that should be just part of the linked doc. Anyhow, take a look at http://apache-beam-website-pull-requests.storage.googleapis.com/438/contribute/index.html#works-in-progress and see what you think.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If at all, you could reference BEAM-2889 under a new portable Flink runner section. I'm not sure how much sense it makes to add directly to the linked doc because that already contains a reference to the umbrella "wordcount runs everywhere" bug (BEAM-2896).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mentioning the Flink runner more prominently both here and on the portability page would be great. I also wanted to reference the progress sheet under status, so it might be a good context to call out Flink.

I don't think we should make it a new section, because it's not a new runner in the same way the others are. But I don't feel very strongly about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I prevail upon one of you two to follow up this PR or issue a PR to my PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do a followup PR.

@kennknowles
Copy link
Member Author

retest this please

@kennknowles
Copy link
Member Author

kennknowles commented May 13, 2018

Ah, the test is failure because of Google's choice to eliminate "research" and only have "AI". A bit of an awkward moniker for FlumeJava.

@kennknowles kennknowles force-pushed the contribution-guide branch from d264be5 to b0c16fd Compare May 13, 2018 03:30
@kennknowles kennknowles force-pushed the contribution-guide branch from b0c16fd to 4284b6a Compare May 13, 2018 03:35
@kennknowles
Copy link
Member Author

retest this please

2 similar comments
@kennknowles
Copy link
Member Author

retest this please

@melap
Copy link

melap commented May 14, 2018

retest this please

Copy link

@melap melap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, much simpler!

@melap
Copy link

melap commented May 14, 2018

not sure how to solve that test failure though ☹️

@kennknowles
Copy link
Member Author

retest this please

@kennknowles
Copy link
Member Author

I believe the problem is with the certs for ai.google combined with our testing library. I'm not sure the appropriate fix here.

@kennknowles
Copy link
Member Author

OTOH I can't repro it on my laptop nor do browsers warn as far as I can tell.

@kennknowles
Copy link
Member Author

Ah, CA issue with the Jenkins worker.

@kennknowles
Copy link
Member Author

Pushed a commit to sickbay that domain for now. Following up separately.

Rakefile Outdated
:check_html => true,
:file_ignore => [/javadoc/, /v2/, /pydoc/],
:url_ignore => [/jstorm.io/, /datatorrent.com/],
:url_ignore => [/jstorm.io/, /datatorrent.com/, /ai.google/],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cite https://issues.apache.org/jira/browse/INFRA-16527 for removal of ai.google?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kennknowles kennknowles force-pushed the contribution-guide branch from aeaa619 to 25a50fe Compare May 15, 2018 04:33
@kennknowles
Copy link
Member Author

@asfgit merge

asfgit pushed a commit that referenced this pull request May 15, 2018
@asfgit
Copy link

asfgit commented May 15, 2018

Error: PR failed in verification; check the Jenkins job for more information.

@kennknowles
Copy link
Member Author

@asfgit merge

asfgit pushed a commit that referenced this pull request May 15, 2018
@asfgit asfgit merged commit 25a50fe into apache:asf-site May 15, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants