Skip to content

Update Python SDK example tests to use assert_that #18029

@kennknowles

Description

@kennknowles

Most of our examples use assert_that to test examples:

https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/complete/autocomplete_test.py#L38

Some of our examples use this pattern:

  1. Create a path(s)
  2. Construct fake command line arguments using these paths
  3. Construct an argparse object to parse these flags
  4. Do the (often trivial logic)
  5. Write to a file
  6. Manually open and read the file
  7. Compare results.

https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py

As well as being cumbersome, this obscures the core of what is being illustrated and tested. As many as possible tests should be updated to use assert_that.

Imported from Jira BEAM-520. Original Jira may contain additional context.
Reported by: altay.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions