Skip to content

outputWithTimestamp() accepts timestamps that will fail preconditions #18188

@kennknowles

Description

@kennknowles

We have accidentally created events with wrong timestamps in the future which are accepted by
outputWithTimestamp(), but will fail at a later step:

java.lang.IllegalStateException: Timer 472976-06-15T20:09:57.269Z is beyond end-of-time
at Preconditions.checkState(Preconditions.java:199)
at ReduceFnRunner.scheduleEndOfWindowOrGarbageCollectionTimer(ReduceFnRunner.java:1050)
[...]

Would it make sense to implement a check already at outputWithTimestamp() level to fail early?

Imported from Jira BEAM-1408. Original Jira may contain additional context.
Reported by: andyxu.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions