[BEAM-9179] Cleanup ZetaSQLQueryPlanner and ExpressionConverter code#10715
Merged
ibzib merged 1 commit intoapache:masterfrom Jan 30, 2020
Merged
[BEAM-9179] Cleanup ZetaSQLQueryPlanner and ExpressionConverter code#10715ibzib merged 1 commit intoapache:masterfrom
ibzib merged 1 commit intoapache:masterfrom
Conversation
ibzib
approved these changes
Jan 29, 2020
| Preconditions.checkState( | ||
| parameter.getType().equals(value.getType()), | ||
| String.format( | ||
| "Expected resolved parameter %s to have type %s, but it has type %s", |
There was a problem hiding this comment.
There are problems with missing ZetaSQL functionality, so we might have to remove this line: #10707
robinyqiu
changed the title
Contributor
Author
|
Hi @ibzib could you help with triggering precommit tests and merging the PR? |
|
retest this please |
|
Dataflow example failure is a known issue (BEAM-9224) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup after #10659 in preparation for https://issues.apache.org/jira/browse/BEAM-9179
r: @ibzib
cc: @kennknowles
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.