Implement java precommit dataflow examples tests to run on java 11

[pawelpasterz]

Implement PreCommit Dataflow Examples to run on java 11

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---		---	---
Java
Python		---			---	---
XLang	---	---	---		---	---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

[mwalenia]

run seed job

[mwalenia]

Run Java_Examples_Dataflow_Java11 PreCommit

[mwalenia]

run seed job

[mwalenia]

Run java precommit

[mwalenia]

Run Java_Examples_Dataflow PreCommit

[mwalenia]

Run Java_Examples_Dataflow_Java11 PreCommit

[mwalenia]

LGTM, when the tests finish, I'll merge it. Thanks for your contribution!

[mwalenia]

Run Java PreCommit

[mwalenia]

Run Java PreCommit

[mwalenia]

Run Java PreCommit

[mwalenia]

Run Java PreCommit

[mwalenia]

run java precommit

[mwalenia]

retest this please

[mwalenia]

retest this please

[kkucharc]

run seed job

[kkucharc]

retest this please

[kkucharc]

Run Java PreCommit

[aaltay]

/cc: @kennknowles

[mwalenia]

@kennknowles do you have anything to add to the review, or can we merge this?

[aaltay]

@kennknowles or @Ardagan - could either one of you review this PR please?

[kennknowles]

Sorry - got this mixed up with a similar PR and lost track.

[kennknowles]

Naively, the idea is:

1. Build and publish Beam main jars with Java 8
2. Build and test with Java 11

I think this PR is on the right path but maybe some more research into how to make this robust?

[kennknowles]

Could this step be a publish?

[kennknowles]

And then this step point to the deps from the prior step?

[kennknowles]

Doing these exclusions seems a fragile. Is there a way to indicate that some dependencies are provided from published cache and not built?

[pawelpasterz]

@kennknowles thanks for all comments, first I thought I will answer to all your comments but then I decided to gather it all in just one. I can see there is lot of knowledge that is missing to me right now, can we contact outside this pr scope? (ex email?) I would very appreciate if you will share some knowledge with me. What do you think?

[Ardagan]

The PR looks valid for me overall. However there's a concern regarding the approach.

Current approach requires someone to maintain the list of exclusions that adds technical debt. Also once we migrate to Java11 we'll have similar issue since we'd want to verify we can still run Java8 pipelines. That would worsen the situation.

Do we have any plan on how to deal with further support of these tests?

Another concern is inline: do we only run tests with Java11 or actually compile test pipelines with Java11?
It would be great if we can add tests that show which version of JVM is used for execution as well as which version of Java was used for compiling tests.
For the first, we can look into ManagementFactory.getRuntimeMXBean().getVmVersion().
Not positive on the best approach for second though.

[mwalenia]

retest this please

[mwalenia]

run seed job

[mwalenia]

Run Java_Examples_Dataflow_Java11 PreCommit

[mwalenia]

Run Java_Examples_Dataflow_Java11 PreCommit

[mwalenia]

Run Java_Examples_Dataflow_Java11 PreCommit

[mwalenia]

Run Java PreCommit