[BEAM-9382] Changes TestStreamTranscriptTest to only inserts two elements#10969
Merged
robertwb merged 1 commit intoapache:masterfrom Feb 26, 2020
Merged
Conversation
…s behavior is the same across all runners.
kennknowles
approved these changes
Feb 25, 2020
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
I agree with this change. The prior test selected one out of multiple allowed behaviors. With this change there is only one allowed behavior. On the other hand, it would be nice to be able to specify a test loosely so that we can test cases that are not edge cases.
robertwb
approved these changes
Feb 26, 2020
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
I also think this make sense for this test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that it's behavior is the same across all runners. Right now a runner must only emit after receiving at least 2 elements since it uses early Count(2) trigger so there's no guarantee the third element will be emitted in the GroupBy.
R: @robertwb
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.