[BEAM-10975] Remove capture_output argument in sdk_container_builder #12942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #12942 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 455 455
Lines 54603 54603
=======================================
+ Hits 44945 44948 +3
+ Misses 9658 9655 -3
Continue to review full report at Codecov.
|
tvalentyn
reviewed
Sep 25, 2020
| _LOGGER.info("Building sdk container, this may take a few minutes...") | ||
| now = time.time() | ||
| subprocess.run(['docker', 'build', '.', '-t', container_image_name], | ||
| capture_output=True, |
Contributor
There was a problem hiding this comment.
How about
subprocess.run([ ], stdout=subprocess.PIPE)
Woud this capture stdout and print STDERR?
Contributor
There was a problem hiding this comment.
If there is an build error, how will users see it?
Contributor
There was a problem hiding this comment.
Not capturing any output should help. But may be noisy. We can consider to capture the output but print it only if something goes wrong.
Leaving the change as is SGMT for now.
tvalentyn
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.