Skip to content

[BEAM-10975] Remove capture_output argument in sdk_container_builder #12942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvalentyn merged 2 commits into from
Sep 25, 2020
Merged

[BEAM-10975] Remove capture_output argument in sdk_container_builder #12942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4afea05
[BEAM-10975] Remove capture_output argument in sdk_container_builder
y1chi Sep 25, 2020
7691022
format
y1chi Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sdks/python/apache_beam/runners/portability/sdk_container_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ def invoke_docker_build_and_push(self, container_image_name):
_LOGGER.info("Building sdk container, this may take a few minutes...")
now = time.time()
subprocess.run(['docker', 'build', '.', '-t', container_image_name],
capture_output=True,
Copy link
Contributor

@tvalentyn tvalentyn Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about
subprocess.run([ ], stdout=subprocess.PIPE)
Woud this capture stdout and print STDERR?

Copy link
Contributor

@tvalentyn tvalentyn Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an build error, how will users see it?

Copy link
Contributor

@tvalentyn tvalentyn Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not capturing any output should help. But may be noisy. We can consider to capture the output but print it only if something goes wrong.
Leaving the change as is SGMT for now.

check=True,
cwd=self._temp_src_dir)
except subprocess.CalledProcessError as err:
Expand All @@ -164,9 +163,7 @@ def invoke_docker_build_and_push(self, container_image_name):
if self._docker_registry_push_url:
_LOGGER.info("Pushing prebuilt sdk container...")
try:
subprocess.run(['docker', 'push', container_image_name],
capture_output=True,
check=True)
subprocess.run(['docker', 'push', container_image_name], check=True)
except subprocess.CalledProcessError as err:
raise RuntimeError(
'Failed to push prebuilt sdk container %s, stderr: \n%s' %
Expand Down