WIP: Resolve beam_fn_api experiment for side inputs, using portable expansion always#13053
Closed
kennknowles wants to merge 4 commits intoapache:masterfrom
Closed
WIP: Resolve beam_fn_api experiment for side inputs, using portable expansion always#13053kennknowles wants to merge 4 commits intoapache:masterfrom
kennknowles wants to merge 4 commits intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
portable-side-inputs
branch
6 times, most recently
from
17587db to
bdf08f6
Compare
Member
Author
|
run dataflow validatesrunner |
4 tasks
Member
Author
4 tasks
kennknowles
force-pushed
the
portable-side-inputs
branch
5 times, most recently
from
eb2d8d4 to
0a496a6
Compare
kennknowles
force-pushed
the
portable-side-inputs
branch
from
0a496a6 to
21f8ffe
Compare
kennknowles
force-pushed
the
portable-side-inputs
branch
from
21f8ffe to
34fd2da
Compare
kennknowles
force-pushed
the
portable-side-inputs
branch
from
34fd2da to
6d526c3
Compare
kennknowles
force-pushed
the
portable-side-inputs
branch
3 times, most recently
from
1b7a90a to
dd32c1c
Compare
4 tasks
…ion always - The SDK now uses the portable expansion always - Runners override to restore pre-portable expansion as needed
kennknowles
force-pushed
the
portable-side-inputs
branch
from
dd32c1c to
326bd65
Compare
This was referenced Apr 25, 2021
Member
Author
|
Managed to do this without the override back to legacy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not review; it doesn't work yet!
Uploading to have an easy UI to browse diffs and kick off test suites
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.