Skip to content

[BEAM-11522] Revert "Optimizes extract_output for 1 element accumulator case."#13612

Merged
tvalentyn merged 2 commits intomasterfrom
revert-13220-patch_cl_339240878
Dec 24, 2020
Merged

[BEAM-11522] Revert "Optimizes extract_output for 1 element accumulator case."#13612
tvalentyn merged 2 commits intomasterfrom
revert-13220-patch_cl_339240878

Conversation

@tvalentyn
Copy link
Contributor

Reverts #13220

Context: #13220 (comment)

@tvalentyn
Copy link
Contributor Author

R: @y1chi @aaltay @pabloem

Copy link
Contributor

@y1chi y1chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Valentyn

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #13612 (24ccdc7) into master (fbeb28e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13612      +/-   ##
==========================================
- Coverage   82.73%   82.72%   -0.01%     
==========================================
  Files         466      466              
  Lines       57522    57518       -4     
==========================================
- Hits        47589    47581       -8     
- Misses       9933     9937       +4     
Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 91.51% <100.00%> (-0.03%) ⬇️
sdks/python/apache_beam/dataframe/frames.py 90.90% <0.00%> (-0.42%) ⬇️
sdks/python/apache_beam/io/iobase.py 84.81% <0.00%> (-0.27%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.44% <0.00%> (-0.26%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 92.42% <0.00%> (+0.75%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 92.85% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbeb28e...24ccdc7. Read the comment docs.

@tvalentyn
Copy link
Contributor Author

Seeing a strange linter flake:

17:33:08 apache_beam/dataframe/frames_test.py:1:0: F0002: <class 'RecursionError'>: maximum recursion depth exceeded while calling a Python object (astroid-error)

@tvalentyn
Copy link
Contributor Author

Run PythonLint Precommit

1 similar comment
@tvalentyn
Copy link
Contributor Author

Run PythonLint Precommit

@tvalentyn tvalentyn merged commit 30a1baf into master Dec 24, 2020
@tvalentyn tvalentyn deleted the revert-13220-patch_cl_339240878 branch December 24, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments