Skip to content

[BEAM-11522] Revert "Optimizes extract_output for 1 element accumulator case." #13612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvalentyn merged 2 commits into from
Dec 24, 2020
Merged

[BEAM-11522] Revert "Optimizes extract_output for 1 element accumulator case." #13612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754a25f
Revert "Optimizes extract_output for 1 element accumulator case. (#13…
tvalentyn Dec 24, 2020
24ccdc7
Add a note on known issue.
tvalentyn Dec 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@
* BigQuery's DATETIME type now maps to Beam logical type org.apache.beam.sdk.schemas.logicaltypes.SqlTypes.DATETIME
* Pandas 1.x is now required for dataframe operations.

## Known Issues

* Non-idempotent combiners built via `CombineFn.from_callable()` or `CombineFn.maybe_from_callable()` can lead to incorrect behavior. ([BEAM-11522](https://issues.apache.org/jira/browse/BEAM-11522)).


# [2.25.0] - 2020-10-23

Expand Down
10 changes: 2 additions & 8 deletions sdks/python/apache_beam/transforms/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,10 +1075,7 @@ def compact(self, accumulator, *args, **kwargs):
return [self._fn(accumulator, *args, **kwargs)]

def extract_output(self, accumulator, *args, **kwargs):
if len(accumulator) == 1:
return accumulator[0]
else:
return self._fn(accumulator, *args, **kwargs)
return self._fn(accumulator, *args, **kwargs)

def default_type_hints(self):
fn_hints = get_type_hints(self._fn)
Expand Down Expand Up @@ -1155,10 +1152,7 @@ def compact(self, accumulator):
return [self._fn(accumulator)]

def extract_output(self, accumulator):
if len(accumulator) == 1:
return accumulator[0]
else:
return self._fn(accumulator)
return self._fn(accumulator)


class PartitionFn(WithTypeHints):
Expand Down