[BEAM-11827] checkJavaLinkage task requires a spread operator for args

[suztomo]

https://issues.apache.org/jira/browse/BEAM-11827

Problem

The sdks/java/build-tools/beam-linkage-check.sh is not working. It fails with "Failed to generate the baseline file. Check the build error above." (full log).

It's because ./gradlew ... -PjavaLinkageWriteBaseline=build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml :checkJavaLinkage task does not generate a file.

Diagnosis

Beam repository has migrated to the Gradle Kotlin DSL recently. The Kotlin Gradle DSL needs to add a spread operator when passing an array to "args" method. Otherwise the DSL passes a String argument from toString of the array (see the screenshot of the problem below; it shows the DSL passed an unexpected String to LinkageCheckerMain):

The fix is to add a spread operator "*" when passing the array to the method.

Confirmation

I confirmed the fix works:

suztomo@suztomo:~/beam$ mkdir build/linkagecheck
suztomo@suztomo:~/beam$ ./gradlew -Ppublishing -PskipCheckerFramework -PjavaLinkageArtifactIds=beam-sdks-java-io-google-cloud-platform -PjavaLinkageWriteBaseline=build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml :checkJavaLinkage
Configuration on demand is an incubating feature.

> Task :checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Wrote the linkage errors as exclusion file: build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
NOTE: This task published artifacts into your local Maven repository. You may want to remove them manually.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 49s
1121 actionable tasks: 203 executed, 918 up-to-date
suztomo@suztomo:~/beam$ ls build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
suztomo@suztomo:~/beam$ head build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
<?xml version="1.0" encoding="UTF-8"?>
<LinkageCheckerFilter>
  <LinkageError>
    <Target>
      <Class name="org.tukaani.xz.LZMAOutputStream"/>
    </Target>
    <Source>
      <Class name="org.apache.beam.repackaged.core.org.apache.commons.compress.compressors.lzma.LZMACompressorOutputStream"/>
    </Source>
  </LinkageError>
suztomo@suztomo:~/beam$ 

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	SDK	Dataflow	Flink	Samza	Spark	Twister2
Go		---		---		---
Java
Python				---		---
XLang				---		---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---		---	---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[suztomo]

This is the latest Linkage Checker version.

[suztomo]

retest this please

[suztomo]

R: @kennknowles @TheNeuralBit
CC: @ramazan-yapparov

While I don't see the Jenkins/GitHub checks running today, the change is for Beam's build tools and is not supposed to affect the checks.

[TheNeuralBit]

LGTM, thanks for tracking this down @suztomo, sorry I didn't catch it.

[suztomo]

@TheNeuralBit Thank you!