Skip to content

Conversation

@ibzib
Copy link

@ibzib ibzib commented Feb 17, 2021

A simple forward fix for concerns about the correctness of BeamJavaUdfCalcRule.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ibzib
Copy link
Author

ibzib commented Feb 17, 2021

R: @amaliujia @apilloud
cc: @kennknowles

@ibzib
Copy link
Author

ibzib commented Feb 17, 2021

Actually, it's probably better to just not add BeamJavaUdfCalcRule to the planner by default. That way we can still test the matching.

@ibzib ibzib closed this Feb 17, 2021
@apilloud
Copy link
Member

I actually like everything here, this change will enable me to submit a compliance test covering BeamJavaUdfCalcRule inside Google.

@ibzib
Copy link
Author

ibzib commented Feb 17, 2021

I actually like everything here, this change will enable me to submit a compliance test covering BeamJavaUdfCalcRule inside Google.

How can we test BeamJavaUdfCalcRule if it never matches anything though? For that reason I think it's better to go with #14009 and then remove BeamJavaUdfCalcRule from the default rules. That way all you have to do to test BeamJavaUdfCalcRule is add the rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants