Closed
Conversation
Contributor
Author
|
+R: @jasonkuster @jasonkuster please test this change to make sure python precommit build as expected and other build will not be affected. |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 8544 lines...][JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/runners/flink/pom.xml to org.apache.beam/beam-runners-flink-parent/0.5.0-incubating-SNAPSHOT/beam-runners-flink-parent-0.5.0-incubating-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/mongodb/pom.xml to org.apache.beam/beam-sdks-java-io-mongodb/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/mongodb/target/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT.jar to org.apache.beam/beam-sdks-java-io-mongodb/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/mongodb/target/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-javadoc.jar to org.apache.beam/beam-sdks-java-io-mongodb/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/mongodb/target/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-sources.jar to org.apache.beam/beam-sdks-java-io-mongodb/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/mongodb/target/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-test-sources.jar to org.apache.beam/beam-sdks-java-io-mongodb/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-test-sources.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/mongodb/target/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-tests.jar to org.apache.beam/beam-sdks-java-io-mongodb/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-mongodb-0.5.0-incubating-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/extensions/sorter/pom.xml to org.apache.beam/beam-sdks-java-extensions-sorter/0.5.0-incubating-SNAPSHOT/beam-sdks-java-extensions-sorter-0.5.0-incubating-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/pom.xml to org.apache.beam/beam-sdks-parent/0.5.0-incubating-SNAPSHOT/beam-sdks-parent-0.5.0-incubating-SNAPSHOT.pomNo artifacts from beam_PreCommit_Java_MavenInstall » Apache Beam :: SDKs #5868 to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/extensions/join-library/pom.xml to org.apache.beam/beam-sdks-java-extensions-join-library/0.5.0-incubating-SNAPSHOT/beam-sdks-java-extensions-join-library-0.5.0-incubating-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/runners/pom.xml to org.apache.beam/beam-runners-parent/0.5.0-incubating-SNAPSHOT/beam-runners-parent-0.5.0-incubating-SNAPSHOT.pomNo artifacts from beam_PreCommit_Java_MavenInstall » Apache Beam :: Runners #5868 to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/jdbc/pom.xml to org.apache.beam/beam-sdks-java-io-jdbc/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/jdbc/target/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT.jar to org.apache.beam/beam-sdks-java-io-jdbc/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/jdbc/target/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-javadoc.jar to org.apache.beam/beam-sdks-java-io-jdbc/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/jdbc/target/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-sources.jar to org.apache.beam/beam-sdks-java-io-jdbc/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/jdbc/target/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-test-sources.jar to org.apache.beam/beam-sdks-java-io-jdbc/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-test-sources.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/jdbc/target/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-tests.jar to org.apache.beam/beam-sdks-java-io-jdbc/0.5.0-incubating-SNAPSHOT/beam-sdks-java-io-jdbc-0.5.0-incubating-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/extensions/pom.xml to org.apache.beam/beam-sdks-java-extensions-parent/0.5.0-incubating-SNAPSHOT/beam-sdks-java-extensions-parent-0.5.0-incubating-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/examples/pom.xml to org.apache.beam/beam-examples-parent/0.5.0-incubating-SNAPSHOT/beam-examples-parent-0.5.0-incubating-SNAPSHOT.pomchannel stoppedSetting status of b1c9f05 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5867/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
markflyhigh
force-pushed
the
python-recommit-maven-install
branch
from
b1c9f05 to
d8fabb2
Compare
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
@jasonkuster any thoughts? CC: @robertwb |
Contributor
|
Could you add a comment (or JIRA issue) as to what issue you're trying to solve here? |
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
Author
|
@robertwb comment updated. |
jasonkuster
requested changes
Jan 9, 2017
Contributor
jasonkuster
left a comment
jasonkuster
left a comment
There was a problem hiding this comment.
This is a good pass; a few comments and then we'll see if we can get this tested.
| admins(['asfbot']) | ||
| useGitHubHooks() | ||
| orgWhitelist(['apache']) | ||
| whiteListTargetBranches(branchWhitelist) |
Contributor
There was a problem hiding this comment.
This should have a default. Optimally, this default would be defined outside of this method, branchWhitelist would be set to it in the method definition, and the default would be commented. Please investigate doing so.
|
|
||
| // Sets that this is a PreCommit job. | ||
| common_job_properties.setPreCommit(delegate, 'Jenkins: Maven clean install') | ||
| common_job_properties.setPreCommit(delegate, ['master'], 'Jenkins: Maven clean install') |
Contributor
There was a problem hiding this comment.
pull ['master'] out into its own var, called something like 'build_branches' and commented. Investigate whether the standard precommit should run on any branch other than master as well.
| mavenjob('beam_PreCommit_Python_MavenInstall') { | ||
| description('Runs an maven install on the python-sdk branch.') | ||
|
|
||
| previousNames('beam_PreCommit_MavenVerify') |
Contributor
There was a problem hiding this comment.
Remove. This job no longer exists.
| common_job_properties.setTopLevelJobProperties(delegate, 'python-sdk') | ||
|
|
||
| // Sets that this is a PreCommit job. | ||
| common_job_properties.setPreCommit(delegate, ['python-sdk'], 'Jenkins: Python PreCommit') |
Contributor
There was a problem hiding this comment.
As above, refactor ['python-sdk'] out into a commented var.
Contributor
|
Is this still necessary now that Python SDK is in master? |
Member
|
Seems like this should be a part of the bigger effort to reorganize the jobs? |
Member
|
@markflyhigh Should this be closed? |
Contributor
|
@aaltay It should -- until we split the Jenkins jobs up there's no point to a separate Python precommit, and this mechanism would no longer work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
After moving Jenkins config to DSL plugin, python-sdk didn't build in beam_Precommit_Java_MavenInstall in a period of time. Triage the issue was very difficult since both python and java builds are shown in one Jenkins branch and no way to filter them by project.
This PR is to make python precommit build shown in separate Jenkins branch for a more clear view.