-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Python Precommit Maven Install #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ mavenJob('beam_PreCommit_Java_MavenInstall') { | |
| common_job_properties.setMavenConfig(delegate) | ||
|
|
||
| // Sets that this is a PreCommit job. | ||
| common_job_properties.setPreCommit(delegate, 'Jenkins: Maven clean install') | ||
| common_job_properties.setPreCommit(delegate, ['master'], 'Jenkins: Maven clean install') | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pull ['master'] out into its own var, called something like 'build_branches' and commented. Investigate whether the standard precommit should run on any branch other than master as well. |
||
|
|
||
| // Maven goals for this job. | ||
| goals('-B -e -Prelease,include-runners,jenkins-precommit,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner help:effective-settings clean install') | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import common_job_properties | ||
|
|
||
| // This job defines the Python precommit which runs a maven install on python-sdk branch. | ||
| mavenjob('beam_PreCommit_Python_MavenInstall') { | ||
| description('Runs an maven install on the python-sdk branch.') | ||
|
|
||
| previousNames('beam_PreCommit_MavenVerify') | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove. This job no longer exists. |
||
|
|
||
| // Execute concurrent builds if necessary. | ||
| concurrentBuild() | ||
|
|
||
| // Set common parameters. | ||
| common_job_properties.setTopLevelJobProperties(delegate, 'python-sdk') | ||
|
|
||
| // Sets that this is a PreCommit job. | ||
| common_job_properties.setPreCommit(delegate, ['python-sdk'], 'Jenkins: Python PreCommit') | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above, refactor ['python-sdk'] out into a commented var. |
||
|
|
||
| // Maven goals for this job. | ||
| goals('-B -e help:effective-settings clean install') | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a default. Optimally, this default would be defined outside of this method, branchWhitelist would be set to it in the method definition, and the default would be commented. Please investigate doing so.