[BEAM-14437] Raise Java HTTP KeepAliveCache size #17585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java HTTP[S]Connection's keep alive by default keeps 5 idle connections alive. Dataflow user workers could make 1000s of connection to the same endpoint. The HTTPS handshake overhead is significant in pipelines using BigQueryIO streaming inserts and bumping up the keep alive limit reduces it. The keep alive connection count can be changed by setting the JVM system property "http.maxConnections".
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Contributor
Author
|
R: @kennknowles |
Contributor
Author
|
I have some trouble with my local docker setup, so couldn't build the containers with the gradle targets locally and test. |
Member
|
Is this going to be a safe default across lots of different contexts? This same code runs locally, during testing, on Spark & Flink & Samza, etc. |
Contributor
Author
Thinking more about this, It is hard to say for sure. Since there is a way to set the setting using JvmInitializers, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java HTTP[S]Connection's keep alive by default keeps 5 idle connections alive. Dataflow user workers could make 1000s of connection to the same endpoint. The HTTPS handshake overhead is significant in pipelines using BigQueryIO streaming inserts and bumping up the keep alive limit reduces it.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.